Questions For Walkthroughs
One list (from Handbook of Walkthroughs, Inspections, and Technical
Reviews by Freedman and Weinberg):
Function
- Is there a concept, an underlying idea, that can be expressed
easily in plain language? Is it expressed in plain language in the
implemented code?
- Does the function of this part have a clear place in the overall
function of the whole, and is this function clearly expressed?
- Is the routine properly sheltered, so that it may perform its
function reliably in spite of possible misuse?
Form
- Whatever style is adopted, is it clean and clear when taken as a
whole?
- Is it meaningful to all classes of readers who will see it?
- Are there repeated code segments, whether within or between
routines?
- Are comments useful or are they simply alibis for poor coding?
- Is the level of detail consistent?
- Are standard practices used?
- Is initialization properly done, and does the routine clean up
after itself?
Economy
- Are there redundant operations for which there is no compensating
benefit?
- Is storage use consistent, both internally and with external
specifications?
- How much will it cost to modify? (Consider the three most likely
future modifications.) [my addition--and consider the three most
likely future mistakes in modification]
- Is it simple?
For a checklist of the process of holding a walkthrough, see
Checklist for Code Walkthroughs